Revert "st: Reload icon on style changes only if necessary"

The size isn't the only relevant style change, we also need to pick
up icon-colors, icon-style and icon-shadow.

This reverts commit 94995e9c1e1ffc3eb44c06d23a30a2ac8cd2455d.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/529

diff --git a/src/st/st-icon.c b/src/st/st-icon.c
index 8b7015281decd3b72865303851bbbbd343226d48..04d2d1d3cc1208028c14ea7c8513482272bf4f46 100644 (file)
--- a/src/st/st-icon.c
+++ b/src/st/st-icon.c
@@ -206,8 +206,8 @@ st_icon_style_changed (StWidget *widget)
     }
 
   priv->theme_icon_size = (int)(0.5 + st_theme_node_get_length (theme_node, "icon-size"));
-  if (st_icon_update_icon_size (self))
-    st_icon_update (self);
+  st_icon_update_icon_size (self);
+  st_icon_update (self);
 }
 
 static void